Skip to content

Conversation

@millerdev
Copy link
Contributor

@millerdev millerdev commented Dec 5, 2025

This was proposed in an earlier PR, but never got merged.

The implementation uses change_filter_fn so it applies to both bulk and single change processing modes. The possibility of change.metadata is None seems like a historical artifact from the days of Couch case change feeds, so the code was written defensively to fail if that ever happens (it should not).

https://dimagi.atlassian.net/browse/SAAS-18496

🐠 Review by commit.

Safety Assurance

Safety story

The bulk processing functionality this inherits from is used in a number of other pillows.

Automated test coverage

Yes.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

No longer relevant since all cases live in SQL.
`change_filter_fn` and `doc_filter_fn` are always functions
@millerdev millerdev requested a review from gherceg December 5, 2025 11:53
@millerdev millerdev added the product/invisible Change has no end-user visible impact label Dec 5, 2025
Copy link
Contributor

@gherceg gherceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product/invisible Change has no end-user visible impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants