Check type hints with mypy #37065
Open
Check type hints with mypy #37065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
dependencies
kaapstorm
force-pushed
the
nh/mypy_2
branch
2 times, most recently
from
85c00b5 to
af797dd
Compare
kaapstorm
requested review from
a team,
biyeun,
esoergel,
orangejenny and
snopoke
as code owners
Contributor
Author
|
@mjriley this is the type checking GitHub Action I mentioned, and a branch I find helpful for navigating unclear parameters. |
Adds type hints for `bulk_update_cases()` parameters so that nobody needs to get them wrong again, and adds type hint for `submit_case_blocks()` return values so that the next person doesn't have to spend half an hour looking them up again.
kaapstorm
commented
Oct 16, 2025
|
|
||
|
|
||
| def bulk_update_cases(domain, case_changes, device_id, xmlns=None): | ||
| type CaseID = str |
Contributor
Author
There was a problem hiding this comment.
The type statement declares an alias, for simplifying types and giving them self-explanatory names. (Python 3.12+)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
submit_case_blocks()andsubmit_form_locally().🐡 🐠 🐟
Safety Assurance
Safety story
No changes to functionality
Automated test coverage
Not applicable
QA Plan
Not applicable
Rollback instructions
Labels & Review