-
-
Notifications
You must be signed in to change notification settings - Fork 230
Bump stripe from 11.4.0 to 13.2.0 #37038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bumps [stripe](https://github.com/stripe/stripe-python) from 11.4.0 to 13.0.1. - [Release notes](https://github.com/stripe/stripe-python/releases) - [Changelog](https://github.com/stripe/stripe-python/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-python@v11.4.0...v13.0.1) --- updated-dependencies: - dependency-name: stripe dependency-version: 13.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
-from stripe.<MODULE> import SomeClass +from stripe import SomeClass
|
A newer version of stripe exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
-https://github.com/stripe/stripe-python/blob/master/CHANGELOG.md #1499 Encode bools with lower case Serializes boolean query parameter values to true/false (lower case) before sending to the Stripe API for compatibility with Stripe V2 endpoints - We were saving autopay as boolean so before 12.0.1 it was getting translated to str representation of bool which is True and False. - After 12.0.1 it got changed to true and false. - is_autopay checks for True - So the fix here is typecasting bool to string before saving metadata
ran uv lock --upgrade-package=stripe
| def _update_autopay_status(self, card, billing_account, autopay): | ||
| stripe.Customer.modify_source(customer=self.customer.id, id=card.id, | ||
| metadata={self._auto_pay_card_metadata_key(billing_account): autopay}) | ||
| metadata={self._auto_pay_card_metadata_key(billing_account): str(autopay)}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may not be following fully, but does str(autopay) need to be str(autopay).lower()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. We check for True as strings in
commcare-hq/corehq/apps/accounting/models.py
Lines 3739 to 3740 in 0ee0cbf
| def _is_autopay(card, billing_account): | |
| return card.metadata.get(StripePaymentMethod._auto_pay_card_metadata_key(billing_account)) == 'True' |
That is why the test was failing in first place.
We were passing in boolean value for autopay here and stripe sdk in the newer version was translating it to true which failed the check in _is_autopay method.
uv.lock
Outdated
| @@ -1,5 +1,5 @@ | |||
| version = 1 | |||
| revision = 3 | |||
| revision = 2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem relevant to the Stripe upgrade, and maybe should be reverted?
What version of UV are you using? I'm on v0.9.5, fwiw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. I think it was caused by my older uv version.
I was on uv 0.7.6 (7f3e94a09 2025-05-19) just upgraded to v0.9.8 and ran uv lock --upgrade-package=stripe and it reverted the change.
Bumps stripe from 11.4.0 to 13.2.0.
Release notes
Sourced from stripe's releases.
... (truncated)
Changelog
Sourced from stripe's changelog.
... (truncated)
Commits
648173bBump version to 13.0.10116885add httpx to optional deps and only ship tests in sdist (#1633)c70d785remove gpg step from publish (#1632)d50cabbRe-addteststo oursdist(#1627)a71c1fdMake nested params classes importable (#1626)62987d6Remove manual promotion code test (#1620)43df6eeupdate doc link (#1619)7bdad07fix publish script (#1612)1632b6cBump version to 13.0.00f3c93eYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)