Upgrade openpyxl #248
Merged
Upgrade openpyxl #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkangia
approved these changes
Jun 6, 2025
Contributor
mkangia
left a comment
mkangia
left a comment
There was a problem hiding this comment.
I assume the tests are good enough to validate the change.
ajeety4
reviewed
Jun 6, 2025
ajeety4
left a comment
ajeety4
left a comment
There was a problem hiding this comment.
Nice 👍
Just curious, how the need to upgrade was identified ? Also wondering if this repo is a good candidate for adding the Dependabot ?
Contributor
Author
Using the Claude CLI, I asked what changes it recommended, and to prioritize those changes. It gave this change the highest priority because of the age of the version (more than 6 years) and the bugs that have been fixed since then.
Yeah, I think so. |
Contributor
Author
|
🤔 looks like we were using Dependabot #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses security vulnerabilities and bug fixes in openpyxl: Changelog