Skip to content

Conversation

@sravfeyn
Copy link
Member

Product Description

Minor UI improvement.

Prefixes a 'Unreleased - ' string to the app names if the app is unreleased, while displaying the apps in the app selection dropdown in opportunity creation

https://dimagi.atlassian.net/browse/CI-413

Technical Summary

Safety Assurance

Safety story

Automated test coverage

QA Plan

Labels & Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@sravfeyn sravfeyn requested a review from pxwxnvermx December 25, 2025 13:42
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

Walkthrough

The _get_commcare_app_json function in commcare_connect/utils/commcarehq_api.py was changed to compute an application name and, when the application's is_released flag is falsy, prefix that name with "Unreleased - " before appending a dictionary containing the application's id and the computed name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'indicate whether an app is released or not' directly relates to the main change: prefixing 'Unreleased - ' to unreleased app names in the selection dropdown.
Description check ✅ Passed The description is related to the changeset, explaining the UI improvement of prefixing 'Unreleased - ' to unreleased apps in the dropdown during opportunity creation.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sr/apprelease

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b23c47 and f0b982b.

📒 Files selected for processing (1)
  • commcare_connect/utils/commcarehq_api.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • commcare_connect/utils/commcarehq_api.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: pytest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8687d9c and 3b23c47.

📒 Files selected for processing (1)
  • commcare_connect/utils/commcarehq_api.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: pytest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants