-
Notifications
You must be signed in to change notification settings - Fork 31
Riese/rm ckeditor #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MartinRiese
wants to merge
14
commits into
master
Choose a base branch
from
riese/rm_ckeditor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Riese/rm ckeditor #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] can undo/redo text in text box - one character at a time - [x] navigating away and back shows text again - [x] copy paste text between fields - [x] drag and drop property - [x] Auto complete on `#` - [x] navigate away and back show bubble again - works if there is more text - Otherwise part of the `#` shows up - [x] getValue does not get called on autocomplete or drag - [x] autocomplete should not get called when cursor is behind bubble - [x] bubble not editable - [x] can move behind bubble Not working: - bubble popover
- [x] Can type in text box - [x] can undo/redo text in text box - one character at a time - [x] navigating away and back shows text again - [x] copy paste text between fields - [x] drag and drop property - [x] Auto complete on `#` - [x] navigate away and back show bubble again - works if there is more text - Otherwise part of the `#` shows up - [x] getValue does not get called on autocomplete or drag - [x] autocomplete should not get called when cursor is behind bubble - [x] bubble not editable - [x] can move behind bubble - [ ] undo/redo adding bubbles - [ ] move cursor after bubble when autocomplete is finished
- [x] Can type in text box - [x] can undo/redo text in text box - one character at a time - [x] navigating away and back shows text again - [x] copy paste text between fields - [x] drag and drop property - [x] Auto complete on `#` - [x] navigate away and back show bubble again - [ ] restores popover - [x] bubble not editable - [x] can move behind bubble - [ ] undo/redo adding bubbles - [x] delete bubble and restore it with undo, including popover - [ ] add bubble and remove it with undo - [ ] move cursor after bubble when autocomplete is finished - [x] popover when hovering over bubble - [x] bubble shows up in question tree if used in name
- [x] Can type in text box - [x] can undo/redo text in text box - one character at a time - [x] navigating away and back shows text again - [x] copy paste text between fields - [x] drag and drop property - [x] Auto complete on `#` - [x] navigate away and back show bubble again - [x] restores popover - [x] bubble not editable - [x] can move behind bubble - [ ] undo/redo adding bubbles - [x] delete bubble and restore it with undo, including popover - [ ] add bubble and remove it with undo - [ ] move cursor after bubble when autocomplete is finished - [x] popover when hovering over bubble - [x] bubble shows up in question tree if used in name
Remove unused code
4e885fe to
7f80d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Feature Flag
Product Description
Safety Assurance
Automated test coverage
QA Plan
Safety story
Rollback instructions