Skip to content

Conversation

@davidlehn
Copy link
Member

  • Work in progress.
  • Pre-epoch dates are failing to roundtrip. Looks like they fail in slightly different ways depending on the date. Might get back 0 or internal cbor errors.
  • dateTime codec needs fixing, should add tests and check date codec too.

@davidlehn davidlehn requested a review from dlongley September 5, 2025 11:42
@davidlehn davidlehn marked this pull request as draft September 5, 2025 11:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (349f9b7) to head (4978120).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   92.17%   92.96%   +0.79%     
==========================================
  Files          35       35              
  Lines        2682     2685       +3     
==========================================
+ Hits         2472     2496      +24     
+ Misses        210      189      -21     
Files with missing lines Coverage Δ
lib/codecs/ValueEncoder.js 95.45% <100.00%> (+0.05%) ⬆️
lib/codecs/XsdDateEncoder.js 85.00% <100.00%> (+8.07%) ⬆️
lib/codecs/XsdDateTimeEncoder.js 89.83% <100.00%> (+26.03%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349f9b7...4978120. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dlongley dlongley marked this pull request as ready for review September 5, 2025 14:43
@dlongley
Copy link
Member

dlongley commented Sep 5, 2025

This PR is ready for review now.

@dlongley dlongley merged commit 6b4bf22 into main Sep 5, 2025
5 checks passed
@dlongley dlongley deleted the fix-datetime branch September 5, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants