Skip to content

std_expr.h: use exprt::check consistently#8831

Merged
tautschnig merged 1 commit intodevelopfrom
std_expr_cleanup
Feb 3, 2026
Merged

std_expr.h: use exprt::check consistently#8831
tautschnig merged 1 commit intodevelopfrom
std_expr_cleanup

Conversation

@kroening
Copy link
Collaborator

This adds missing calls to the static check method of the expressions subclasses in std_expr.h.

The subsequently unused validate_expr functions are removed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds missing calls to the static check method of the expressions
subclasses in std_expr.h.

The subsequently unused validate_expr functions are removed.
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 80.18868% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.00%. Comparing base (0b937eb) to head (f6a9578).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/std_expr.h 80.18% 21 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8831   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files         1700     1700           
  Lines       188345   188248   -97     
  Branches        73       73           
========================================
- Hits        150689   150613   -76     
+ Misses       37656    37635   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit af0b511 into develop Feb 3, 2026
40 of 42 checks passed
@tautschnig tautschnig deleted the std_expr_cleanup branch February 3, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants