Fix basic block coverage with unsatisfiable ASSUME statements#8791
Closed
tautschnig wants to merge 1 commit intodiffblue:developfrom
Closed
Fix basic block coverage with unsatisfiable ASSUME statements#8791tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8791 +/- ##
========================================
Coverage 79.93% 79.93%
========================================
Files 1698 1698
Lines 187698 187698
Branches 73 73
========================================
Hits 150034 150034
Misses 37664 37664 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Insert coverage assertions at the end of basic blocks instead of the beginning to ensure blocks are only marked as covered when all instructions, including ASSUME statements, can be executed. Fixes: diffblue#826
d5cab1c to
f03192d
Compare
Collaborator
Author
|
Closing as this was already taking care of in #7810. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insert coverage assertions at the end of basic blocks instead of the beginning to ensure blocks are only marked as covered when all instructions, including ASSUME statements, can be executed.
Fixes: #826