Fix misleading error message for --generate-function-body on existing bodies#8786
Merged
tautschnig merged 1 commit intodiffblue:developfrom Jan 9, 2026
Conversation
c359c35 to
7893fc0
Compare
… bodies Previously, when the option was used with a function name that matched an existing function that already had a body, the error message incorrectly stated "No function name matched regex", which confused users into thinking their regex was wrong when in fact the function was found but had an existing body. The fix improves user experience by providing clear, actionable error messages that distinguish between: - Functions that don't match the provided regex - Functions that match the regex but already have bodies (and thus cannot have bodies generated) Fixes: diffblue#2974
7893fc0 to
5a1e105
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8786 +/- ##
========================================
Coverage 79.93% 79.94%
========================================
Files 1698 1698
Lines 187698 187703 +5
Branches 73 73
========================================
+ Hits 150034 150053 +19
+ Misses 37664 37650 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kroening
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when the option was used with a function name that matched an existing function that already had a body, the error message incorrectly stated "No function name matched regex", which confused users into thinking their regex was wrong when in fact the function was found but had an existing body.
The fix improves user experience by providing clear, actionable error messages that distinguish between:
Fixes: #2974