Remove SSA thread suffix in goto trace address-of expressions#8761
Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
Draft
Remove SSA thread suffix in goto trace address-of expressions#8761tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
SSA thread suffixes (e.g., "!0", "@1") are internal SSA identifiers that should be removed when displaying trace information to users. Similar SSA suffix removal logic already existed in `src/goto-programs/graphml_witness.cpp` (the `remove_l0_l1` function), but this logic was not being applied to expressions in the goto trace formatting code. Fixes: diffblue#902
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSA thread suffixes (e.g., "!0", "@1") are internal SSA identifiers that should be removed when displaying trace information to users. Similar SSA suffix removal logic already existed in
src/goto-programs/graphml_witness.cpp(theremove_l0_l1function), but this logic was not being applied to expressions in the goto trace formatting code.Fixes: #902