Rewrite byte_extract from multi-dimensional array#8705
Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
Draft
Rewrite byte_extract from multi-dimensional array#8705tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8705 +/- ##
===========================================
+ Coverage 80.00% 80.01% +0.01%
===========================================
Files 1700 1700
Lines 188249 188261 +12
Branches 73 73
===========================================
+ Hits 150615 150646 +31
+ Misses 37634 37615 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0ae1c7e to
9a19114
Compare
Collaborator
Author
|
Now includes a minified version of the sample provided in #8796 to confirm the desired effect of the simplification improvement. |
020d67c to
15e460c
Compare
As a follow-up to 78839a9: add support for rewriting multiple-of-element size access to arrays when working with multi-dimensional arrays. Fixes: diffblue#8796
15e460c to
4f514db
Compare
Collaborator
|
Can we push this to the top of the queue to be reviewed please? This is blocking progress on mldsa-native. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to 78839a9: add support for rewriting multiple-of-element size access to arrays when working with multi-dimensional arrays.
Fixes: #8796