Open
Conversation
dhylands
requested changes
Jul 11, 2018
Owner
dhylands
left a comment
There was a problem hiding this comment.
I tried to run this on my dev machine and got this error:
581 >./find_port.py
Traceback (most recent call last):
File "./find_port.py", line 143, in <module>
main()
File "./find_port.py", line 136, in main
if is_usb_serial(device, **args):
TypeError: is_usb_serial() argument after ** must be a mapping, not Namespace
I tried using both python2 and python3
Contributor
Author
|
I have fixed this bug and tested it in both python2 and 3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this additions, find port can be imported as module. Furthermore I removed unused imports and code.