Skip to content

fix(icon picker): handle img load properly #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mohammer5 wants to merge 1 commit into
base: brute-force
Choose a base branch
from
Open

fix(icon picker): handle img load properly #2195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/forms/form-fields/helpers/IconPickerDialog/Icon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
import { Component } from 'react';
import { Component, createRef } from 'react';
import PropTypes from 'prop-types';

export default class Icon extends Component {
constructor(props) {
super(props);
this.img = null;

this.setImgRef = (element) => {
this.img = element;
};
this.img = createRef();
}

componentDidMount() {
this.img.onload = () => {
this.img.removeAttribute('data-loading');
};
const img = this.img.current

if (img?.current) {
img.onload = this.handleLoad;
}
}

handleLoad = () => {
this.img.current.removeAttribute('data-loading');
}

handleClick = () => {
Expand All @@ -28,13 +30,14 @@ export default class Icon extends Component {
/* eslint-disable */
return (
<img
ref={this.setImgRef}
ref={this.img}
src={href}
alt={title}
title={title}
data-loading
className={`icon-picker__icon${classSuffix}`}
onClick={this.handleClick}
onLoad={this.handleLoad}
/>
);
/* eslint-enable */
Expand Down