feat: add header and footer support to Drawer component#763
Open
Chisomchima wants to merge 2 commits intomasterfrom
Open
feat: add header and footer support to Drawer component#763Chisomchima wants to merge 2 commits intomasterfrom
Chisomchima wants to merge 2 commits intomasterfrom
Conversation
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Implements header and footer areas for the Drawer component as specified in DHIS2-20791. The header accepts a title (and optionally a tag), and the footer accepts any content. Both header and footer are fixed, with content scrolling between them.
Changes
Core Drawer Component
headerandfooterprops toDrawercomponentglobalShellEnabledsystem settingUpdated Modules
All modules using Drawer have been updated to use the new header/footer pattern:
ProgramStagesFormContents: Program stage formsOptionsListFormContents: Option formsSectionFormList: Data set section formsCustomFormEditEntry: Custom form editorDataSetSectionForm: Data set section formsTechnical Details
Dynamic Header Bar Height
The Drawer component now dynamically adjusts its position based on the app shell version see DHIS2-20789:
useSystemSettingsStoreto detectglobalShellEnabledtopandheightto position drawer below header barForm Action Pattern
Forms now expose their actions via
onActionsReadycallback: