fix: add a html base element and patch react-router to respect it#541
Open
fix: add a html base element and patch react-router to respect it#541
Conversation
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
Leaving this as draft but opening for @Birkbjo and @dhis2/platform-frontend to take a look |
Member
Author
|
The downside of this fix is that it does not work in a "standalone" environment (like the netlify preview...) |
Member
Author
|
Thanks @KaiVandivier for fixing standalone builds! Looks like there's an issue with patch-package though https://www.dropbox.com/scl/fi/heegfa4utkkvp397xet8r/Screenshot-2025-04-14-at-16.18.04.png?rlkey=cvaktbn9zpzh7vh0j0qrmcq87&dl=0 |
17 tasks
KaiVandivier
force-pushed
the
fix-html-base
branch
from
ab27472 to
601f9ae
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-19412
Specifying a base in html (
<base href="__DHIS2_APP_BASE_URL__/" />) allows native anchor links with hash targets to always link to the base with hash appended (see MDN docs here).Unfortunately, there is also a bug in
react-routerhere which checks for a specifiedbase.hrefattribute but then useswindow.location.hrefinstead ofbase.hrefordocument.baseURI(see here) as the base location for anchor links created with the<Link>component. This change patches that bug, which we should also open as a PR against the upstream library.Note that this may cause a full refresh in the case where
?redirect=falseis set by the global shell - a separate change in the global shell should be able to prevent this.