fix: indicate supported version for GML [DHIS2-18232]#2196
Merged
BRaimbault merged 4 commits intomasterfrom Sep 12, 2025
Merged
fix: indicate supported version for GML [DHIS2-18232]#2196BRaimbault merged 4 commits intomasterfrom
BRaimbault merged 4 commits intomasterfrom
Conversation
Contributor
|
🚀 Deployed on https://pr-2196--dhis2-import-export.netlify.app |
BRaimbault
changed the title
tomzemp
approved these changes
Sep 11, 2025
Member
tomzemp
left a comment
tomzemp
left a comment
There was a problem hiding this comment.
Looks good; thanks 🙏. See comment re: the translation parsing.
| <FileUpload | ||
| helpText={i18n.t( | ||
| 'Supported version: GML 2.0 only.' | ||
| )} |
Member
There was a problem hiding this comment.
can you add a non-standard nsSeparator as an option here, e.g.
helpText={i18n.t('Supported version: GML 2.0 only.', { nsSeparator: '>' })?
otherwise, the i18next-scanner will not correctly scan the text for the en.pot file.
|
dhis2-bot
added a commit
that referenced
this pull request
Sep 12, 2025
## [101.1.30](v101.1.29...v101.1.30) (2025-09-12) ### Bug Fixes * indicate supported version for GML import [DHIS2-18232] ([#2196](#2196)) ([5fde9dc](5fde9dc))
Contributor
|
🎉 This PR is included in version 101.1.30 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: https://dhis2.atlassian.net/browse/DHIS2-18232