chore: align logging configuration keys under logging.* namespace DHIS2-20960#22995
chore: align logging configuration keys under logging.* namespace DHIS2-20960#22995
Conversation
8831c1f to
0cb8334
Compare
|
|
||
| /** Database debugging feature. Defines threshold for logging of slow queries in the log. */ | ||
| LOGGING_QUERY_SLOW_THRESHOLD( | ||
| "logging.query.slow_threshold", String.valueOf(SECONDS.toMillis(1)), false), |
There was a problem hiding this comment.
@netroms is that not a pretty low default? 😅 at least from what I see our queries take
...upport/dhis-support-external/src/main/java/org/hisp/dhis/external/conf/ConfigurationKey.java
Show resolved
Hide resolved
|
I agree but I would still find a way to communicate these changes (not sure if it make sense to have it in release notes or have a message on some slack channel) so anyone interested is warned that they have changed. I am just thinking that for @bobjolliffe or anyone like him would be helpful to know that they changed. |
I'll write it into the release notes 👌🏻 |



Align logging-related
dhis.confkeys under a consistentlogging.*namespace. These configs are targeted at developers debugging DHIS2 instances, not end users, so we do not need to maintain backward compatibility.logging.request_id.enabledwas renamed tologging.session_idbecause the old name was misleading. The feature does not deal with request IDs. It adds a hashed session ID to the MDC (sessionIdkey), which log4j2 can include in log output via%X{sessionId}.Renames
enable.query.logginglogging.queryslow.query.logging.threshold.timelogging.query.slow_thresholdmethod.query.logging.enabledlogging.query.methodlogging.request_id.enabledlogging.session_idRemoved
elapsed.time.query.logging.enabledQuery took Xmsecafter every query, which is a noisier, less useful version of whatlogging.query.slow_thresholdalready provides (logs slow queries at WARN level with the full query text).