refactor(test): [Login] Update test annotations to use Kotlin test framework

[andresmr]

Description

Replace JUnit by Kotlin Test Framework

[Copilot]

Pull request overview

This PR updates the login module’s commonTest tests to use Kotlin’s kotlin.test annotations (e.g., @BeforeTest, @AfterTest) instead of JUnit annotations, aligning tests with Kotlin Multiplatform conventions.

Changes:

• Replaced JUnit lifecycle annotations (@Before, @After) with Kotlin test equivalents (@BeforeTest, @AfterTest) across several commonTest classes.
• Switched JUnit assertions/imports to kotlin.test in GetInitialScreenUseCaseTest.
• Removed unused Koin test dependencies from commonTest in login/build.gradle.kts.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
login/src/commonTest/kotlin/org/dhis2/mobile/login/pin/ui/viewmodel/PinViewModelTest.kt	Replace JUnit @Before with @BeforeTest for KMP-friendly test lifecycle.
login/src/commonTest/kotlin/org/dhis2/mobile/login/pin/domain/usecase/ValidatePinUseCaseTest.kt	Replace JUnit @Before with @BeforeTest.
login/src/commonTest/kotlin/org/dhis2/mobile/login/pin/domain/usecase/SavePinUseCaseTest.kt	Replace JUnit @Before with @BeforeTest.
login/src/commonTest/kotlin/org/dhis2/mobile/login/pin/domain/usecase/GetInitialScreenUseCaseTest.kt	Replace JUnit imports/@Before and assertion import with kotlin.test equivalents.
login/src/commonTest/kotlin/org/dhis2/mobile/login/pin/domain/usecase/ForgotPinUseCaseTest.kt	Replace JUnit @Before with @BeforeTest.
login/src/commonTest/kotlin/org/dhis2/mobile/login/main/ui/viewmodel/LoginViewModelTest.kt	Replace JUnit @Before with @BeforeTest.
login/src/commonTest/kotlin/org/dhis2/mobile/login/main/ui/viewmodel/CredentialsViewModelTest.kt	Replace JUnit @Before/@After/@Test imports with kotlin.test equivalents.
login/src/commonTest/kotlin/org/dhis2/mobile/login/main/LoginScreenIntegrationTest.kt	Expand KDoc scenario description with Given/When/Then and examples table.
login/build.gradle.kts	Remove Koin test dependencies from commonTest source set.

Comments suppressed due to low confidence (2)

login/src/commonTest/kotlin/org/dhis2/mobile/login/main/ui/viewmodel/LoginViewModelTest.kt:50

• Dispatchers.setMain(testDispatcher) is configured in @BeforeTest but there is no corresponding Dispatchers.resetMain() cleanup. This can affect subsequent tests in the same run. Add an @AfterTest to reset Main after each test.

    @BeforeTest
    fun setUp() {
        Dispatchers.setMain(testDispatcher)
        whenever(appLinkNavigation.appLink).thenReturn(mockAppLinkFlow)
        whenever(networkStatusProvider.connectionStatus).thenReturn(mockNetworkStatusFlow)
    }

login/build.gradle.kts:65

• PR description says JUnit is being replaced by Kotlin test, but there are still org.junit.* imports under login/src/commonTest (e.g., authentication/ui/viewmodel/TwoFASettingsViewModelTest.kt, main/domain/usecase/LoginUserTest.kt). With commonTest depending on kotlin("test"), leaving JUnit-based annotations in common sources is inconsistent and may break non-JVM metadata compilation. Either migrate the remaining tests to kotlin.test.* or move them to a JVM-only source set (or keep the required JUnit deps explicitly).

        commonTest {
            dependencies {
                implementation(kotlin("test"))
                implementation(libs.test.turbine)
                implementation(libs.test.kotlinCoroutines)
                implementation(libs.test.mockitoKotlin)
                implementation(compose.components.resources)
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

login/src/commonTest/kotlin/org/dhis2/mobile/login/main/ui/viewmodel/LoginViewModelTest.kt:50

• The test class sets the main dispatcher in the setUp method but lacks a corresponding tearDown method with @AfterTest annotation to reset the dispatcher. This can cause test isolation issues and resource leaks. Other test files in this PR (PinViewModelTest.kt and CredentialsViewModelTest.kt) properly include @AfterTest methods that call Dispatchers.resetMain(). Add a tearDown method with @AfterTest annotation that calls Dispatchers.resetMain(), and import kotlinx.coroutines.test.resetMain.

    @BeforeTest
    fun setUp() {
        Dispatchers.setMain(testDispatcher)
        whenever(appLinkNavigation.appLink).thenReturn(mockAppLinkFlow)
        whenever(networkStatusProvider.connectionStatus).thenReturn(mockNetworkStatusFlow)
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud