refactor: enable ruff UP (pyupgrade) lint rules#208
Merged
Conversation
Add "UP" to ruff select rules and fix all 457 violations: - UP045: Optional[X] -> X | None - UP006: typing.List -> list, typing.Dict -> dict, etc. - UP035: deprecated typing imports -> collections.abc equivalents - UP015: redundant open() modes - UP007: Union[X, Y] -> X | Y - UP046: Generic[T] -> PEP 695 type parameter syntax - UP037: remove quotes from annotations - UP017: datetime.timezone.utc -> datetime.UTC - UP040: PEP 695 type alias syntax - UP028: yield in for loop -> yield from - UP031: printf-style formatting -> f-strings
mortenoh
force-pushed
the
refactor/enable-ruff-up-rules
branch
from
dba78d0 to
9a980f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UP(pyupgrade) rule group in ruff alongside the existingI(import sorting) ruleschap_core/Violation breakdown
Optional[X]->X | Nonetyping.List->list,typing.Dict->dicttyping.Iterable->collections.abc.Iterable)open()modesUnion[X, Y]->X | Y(str, Enum)->StrEnumdatetime.timezone.utc->datetime.UTCyieldin for loop ->yield fromTest plan
uv run ruff check chap_core/passes with zero violationsmake lintpasses (ruff check + ruff format + mypy -- mypy errors are pre-existing)make testpasses (538 passed, 118 skipped)