End-to-end tests v2 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #66.
Q1. 1.2 test case of the original Recreation spec ('should not reset Datasource on destroy via ngIf') doesn't make sense without Angular environment. It raises a principal question at the core level. What if the viewport element gets destroyed? Perhaps we'd want to have a MutationObserver subscription which forces workflow.dispose call when the viewport is removed. We also might want to have it implemented at the DOM Routines class with possibility of overriding: Routines.onViewportRemoved. This is important for the consumers flow. For example, ngx-ui-scroll handles this situation via Angular standard mechanism, so Routines.onViewportRemoved should just do nothing there. But having this functionality inside core, we could reconsider this test case.
Q2. In ngx-ui-scroll recreation tests, after each ngIf-recreation we have the same picture as we have after the initial run, because Angular cleans up the DOM. In current vscroll recreation spec implementation we make this cleanup at the spec level. Maybe we want to do it at the core level: clean up the scroller's DOM when calling Workflow.dispose.