chore: Switch to unbounded anchor memory #3571
Merged
+832
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterga
requested review from
Copilot,
roelstorms and
sea-snake
and removed request for
sea-snake
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches Internet Identity to use unbounded anchor memory, lifting the previous 4KB restriction per anchor. The changes enable the system to read anchors from the new unbounded stable memory structure, with a fallback mechanism to legacy memory for backward compatibility.
Changes:
- Modified
Storage.read()to attempt reading from unbounded stable memory first, falling back to legacy memory if not found - Added comprehensive migration test suite covering 18 test cases for various device types and edge cases
- Made Anchor struct fields
pub(crate)to enable direct construction in migration tests - Uncommented metadata assertion test that expects metadata to be None in the new storage
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/internet_identity/src/storage.rs | Refactored read logic to create read_legacy() method and updated read() to attempt new storage first with fallback |
| src/internet_identity/src/storage/anchor.rs | Changed Anchor struct field visibility from private to pub(crate) to support test construction |
| src/internet_identity/src/storage/tests.rs | Added comprehensive migration test with 18 test cases covering device types, metadata preservation, and edge cases |
| src/internet_identity/tests/integration/anchor_management/device_management.rs | Removed TODO and uncommented metadata assertion expecting None |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Lift the 4KB restriction per anchor.
Changes
Storage.readnow attempts to read anchors from the new, unbounded stable memory, falling back to legacy memory (for now).Tests
Added comprehensive migration test with 18 test cases covering device types, metadata preservation, and edge cases.