chore(firewall): remove obsolete default firewall config path#9342
Draft
pierugo-dfinity wants to merge 3 commits intomasterfrom
Draft
chore(firewall): remove obsolete default firewall config path#9342pierugo-dfinity wants to merge 3 commits intomasterfrom
pierugo-dfinity wants to merge 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The orchestrator's firewall uses two orthogonal ways to detect that it is running in a testnet: whether or not the config file is the default value and whether or not there are rules in the registry. This is confusing and error-prone.
In practice, we now always use the second way since the config file is set in the
ic.json5template. Indeed, no testnet logged the first way in the past months. This PR thus removes the ability to disable the firewall.