refactor: move decode_registry_value into shared pocket_ic_helpers#9334
Draft
jasonz-dfinity wants to merge 1 commit intojason/migrate-create-subnet-test-to-state-machinefrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Multiple registry canister tests repeat the same boilerplate: call get_value, match on Content::Value, then prost::Message::decode. This is verbose (especially the fully-qualified Content path in swap_node_in_subnet_directly.rs) and duplicated across test files.
What
Move the generic decode_registry_value<T: Message + Default> helper from create_subnet.rs into the shared ic_nervous_system_integration_tests::pocket_ic_helpers::nns::registry module, and update both create_subnet.rs and swap_node_in_subnet_directly.rs to use it.
PR Chain