Skip to content

test: add a single test for systemctl#9328

Merged
shilingwang merged 8 commits intomasterfrom
shiling/new-test
Mar 13, 2026
Merged

test: add a single test for systemctl#9328
shilingwang merged 8 commits intomasterfrom
shiling/new-test

Conversation

@shilingwang
Copy link
Contributor

@shilingwang shilingwang commented Mar 12, 2026

No description provided.

@github-actions github-actions bot added the test label Mar 12, 2026
@shilingwang shilingwang marked this pull request as ready for review March 12, 2026 15:27
@shilingwang shilingwang requested a review from a team as a code owner March 12, 2026 15:27
@github-actions github-actions bot added the @node label Mar 12, 2026
@andrewbattat andrewbattat mentioned this pull request Mar 12, 2026
Closed
r-birkner
r-birkner reviewed Mar 12, 2026
View reviewed changes
andrewbattat
andrewbattat previously approved these changes Mar 12, 2026
View reviewed changes
frankdavid
frankdavid reviewed Mar 12, 2026
View reviewed changes
@andrewbattat andrewbattat dismissed their stale review March 12, 2026 20:21

Removing review after reverting my changes

basvandijk
basvandijk reviewed Mar 13, 2026
View reviewed changes
@shilingwang @basvandijk
Update rs/tests/node/guestos_no_failed_systemd_units.rs
f483514 
Co-authored-by: Bas van Dijk <bas@dfinity.org>
@shilingwang shilingwang requested a review from basvandijk March 13, 2026 15:39
basvandijk
basvandijk approved these changes Mar 13, 2026
View reviewed changes
@shilingwang shilingwang enabled auto-merge March 13, 2026 17:02
basvandijk
basvandijk reviewed Mar 13, 2026
View reviewed changes
Copy link
Collaborator

@basvandijk basvandijk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing: you want to add the test to the Cargo.toml file as well such that rust-analyzer will analyze it.

Disabled the auto-merge so you'll have a chance to do ^

@basvandijk basvandijk disabled auto-merge March 13, 2026 17:05
@shilingwang
Copy link
Contributor Author

shilingwang commented Mar 13, 2026

One last thing: you want to add the test to the Cargo.toml file as well such that rust-analyzer will analyze it.

Disabled the auto-merge so you'll have a chance to do ^

Done.

@shilingwang shilingwang enabled auto-merge March 13, 2026 17:40
@shilingwang shilingwang added this pull request to the merge queue Mar 13, 2026
Merged via the queue into master with commit 5ca84e8 Mar 13, 2026
38 checks passed
@shilingwang shilingwang deleted the shiling/new-test branch March 13, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basvandijk basvandijk basvandijk approved these changes

@frankdavid frankdavid frankdavid approved these changes

@andrewbattat andrewbattat andrewbattat approved these changes

@r-birkner r-birkner Awaiting requested review from r-birkner

Assignees

No one assigned

Labels

@node test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shilingwang @basvandijk @frankdavid @r-birkner @andrewbattat