feat(firewall): firewall adjustments for cloud engine nodes#9315
Draft
pierugo-dfinity wants to merge 19 commits intomasterfrom
Draft
feat(firewall): firewall adjustments for cloud engine nodes#9315pierugo-dfinity wants to merge 19 commits intomasterfrom
pierugo-dfinity wants to merge 19 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the firewall to support cloud engine nodes. Cloud engine nodes (reward type:
type4) have different trust assumptions and should (for now) be outside the firewall, i.e., not be able to talk to non-type4nodes.Here are the intended rules for each node type/role:
type4API BN will not exist for now is configured just like a non-type4API BN for now (see below). They should probably be configured differently in the future.type4node accepts traffic from all nodes. In particular, they need to accept incoming connections from regular API BNs to allow the latter to forward traffic. In the future, they could allow traffic fromtype4nodes only, iftype4API BNs exist.type4node accepts traffic from all buttype4nodes. In particular, this means that atype4API BN (should they exist) will not be able to connect to them.type4API BN will open their SOCKS proxy port only to (system) subnets or (app + verified app) subnets, depending if they are a system- or app-API BN respectively. Note thattype4nodes will thus not be able to connect to non-type4API BN's SOCKS proxy.Also,
type4nodes, just like a non-type4node.The golden tests have been greatly extended to test combinations of
type4/non-type4nodes as well as for unassigned nodes.