fix: persist next_idx over checkpoint for LogMemoryStore#9309
Draft
fix: persist next_idx over checkpoint for LogMemoryStore#9309
Conversation
maksymar
changed the title
maksymar
changed the title
maksymar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures canister log record unique
idxis preserved over checkpoint and other lifecycle events.Previously the
next_idxwas stored insideLogMemoryStore::maybe_page_map, and reset to zero whenever the underlying page_map was dropped. This PR introduced apersisten_next_idxfield in LogMemoryStore that persists independently of that page_map, acting as a high-water mark. This guarantees index continuity even if the caniser is uninstalled and re-installed.