Open
Conversation
geniem-jonipievilainen
suggested changes
Sep 14, 2023
geniem-jonipievilainen
left a comment
geniem-jonipievilainen
left a comment
There was a problem hiding this comment.
Todella hyvä näköistä koodia. Pieniä näennäisiä fixejä kommenteissa. Kurkkaa ne läpi.
Ja kurkkaa tarviiko assets kansiota ollenkaan. Muutoksissasi lähtee wp_enqueue_script:ä pois, niin ei välttämättä niissä käytettyjä tiedostoja tarvitse enää pitää tallessa?
src/Plugin.php
Outdated
| * @return array | ||
| */ | ||
| private function register_page_template( $templates ) : array { | ||
| $templates['page-lunch-menus-list.php'] = __( 'Lounaslista' ); |
There was a problem hiding this comment.
Varmaan tarvis käänökselle domaini? tms-plugin-lunch-menus
src/Plugin.php
Outdated
| ); | ||
| } | ||
| public function load_localization() { | ||
| load_plugin_textdomain( |
There was a problem hiding this comment.
\load_plugin_textdomain
| 'boilerplate-admin-css', | ||
| $this->dist_uri . 'admin.css', | ||
| [], | ||
| $this->mod_time( 'admin.css' ), |
There was a problem hiding this comment.
admin.css ei ole poistettu distin alta
| 'boilerplate-public-js', | ||
| $this->dist_uri . 'public.js', | ||
| [ 'jquery' ], | ||
| $this->mod_time( 'public.js' ), |
There was a problem hiding this comment.
public.js löytyy edelleen dist:n alta
| 'boilerplate-admin-js', | ||
| $this->dist_uri . 'admin.js', | ||
| [ 'jquery' ], | ||
| $this->mod_time( 'admin.js' ), |
There was a problem hiding this comment.
admin.js löytyy edelleen distin alta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
Local, stage
Types of changes
Checklist: