Add option to split CLI wallet into 2 roles: an online (view only) & offline (sign) wallet #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Touching up layout
Verbose feedback if any error is detected during wallet creation. Save wallet to disk immediately after its creation
Apply wallet default save interval (300 seconds) if parameter isn't specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[dero-wallet-cli]
[All functionality was tested and creates no crashes]
These patches allow the split of your wallet into an online part and an offline (cold storage) part.
The offline wallet only holds your secret key. The offline wallet creates a 'viewing key' and the 'registration transaction' which are used to setup its online counterpart wallet.
The online wallet contains your public Dero address and public key. It can display your account balance and transaction history. It can also create a transaction but not authorise (sign) it.
The assistance of the offline wallet is required to decrypt blockchain data, in order to reconstruct the transaction history and account balance, as well as to sign transactions that were created on the online (viewing) wallet.
This code forms a stepping stone towards integration with the Pirate+ hardware wallet, but can run completely independent as is.
Since the data files has to be exchanged between the online (viewing) and offline (signing) wallet for every transaction in your wallet, this can become quite impractical in a production environment where the offline wallet is disconnected & remote from the online wallet.
For testing purposes the online & offline wallet can be run on the same machine, where they'll exchange data with one another locally.
The command line help was expanded to document the new commandline options to setup the 2 wallet roles (online & offline).
A detailed help file is located in the top level of the project: README_offline_transaction_signing.md that takes you through al the steps to setup and use the split wallet topology.