ocaml: prepare for filetype separation, drop ols support#3732
Merged
hsanson merged 1 commit intodense-analysis:masterfrom May 27, 2021
Merged
ocaml: prepare for filetype separation, drop ols support#3732hsanson merged 1 commit intodense-analysis:masterfrom
hsanson merged 1 commit intodense-analysis:masterfrom
Conversation
The ocaml filetype is currently used for several, different file formats. This causes problems as not all tools support all formats. New filetypes are introduced to support this separation, this needs some changes in ale that are fortunately backwards-compatible. These change add ocamlinterface file support for ocp-indent, merlin, ocamlformat and ocaml-lsp. For ocaml-lsp I took the liberty to add all recognised language ids, even if they are not supported. ols has not been changed as the project has been abandoned since 2019.
10 tasks
Contributor
Author
|
appveyor failure is unrelated to the change: |
hsanson
requested changes
May 25, 2021
Contributor
hsanson
left a comment
hsanson
left a comment
There was a problem hiding this comment.
Changes seem ok except for removing ols that is a potential breaking change. Currently there is no defined procedure to remove supported tools from ALE and I would refrain from doing so unless is first announced (somehow) to give users time to phase the tool out or request it not to be removed.
I recommend moving the changes to remove ols support to a separate PR with an associated issue to inform and start discussion on if is ok to remove it from ALE.
Contributor
Author
|
That makes sense, I'll remove the changes to remove ols. |
hsanson
approved these changes
May 27, 2021
Contributor
hsanson
left a comment
hsanson
left a comment
There was a problem hiding this comment.
Thanks for the changes. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ocaml filetype is currently used for several, different file
formats. This causes problems as not all tools support all formats.
New filetypes are introduced to support this separation, this needs some
changes in ale that are fortunately backwards-compatible.
These change add ocamlinterface file support for ocp-indent, merlin,
ocamlformat and ocaml-lsp. For ocaml-lsp I took the liberty to
add all recognised language ids, even if they are not supported.
ols has been removed as the project has been abandoned since 2019,
users are better served by other tools.
The PR for splitting the filetypes is at ocaml/vim-ocaml#61