Feature 371 maven build setup #423
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently not building anything just setting up the build and Github action Using the target platform during the Maven build and build the css plug-in
Search and refactoring were the only plug-ins defining a minimum version and this version did not fit to the target platform. By removing the version we enable the plug-in to resolve them with the giving target platform.
This should help with solving the strange version range issue.
- added commons-io 2.7 (originally used io 2.6 but had a vulnerability so used 2.7 now to too many issues with upgrade at the moment - added eclipse-commons 1.0.0 dependency - added asciidoctor j launcher dependency
- unfortunately the runtime dependencies (asciidoctorj for example) seems to be not resolved by asciidoctor-editor-target
Also removes commented reference to libs project. For #371 Requires de-jcup/eclipse-commons#39
- eclipse commons dependency do now work - switched also back to asp 1.3.1 because in asp 1.4.0 there are breaking changes which must be still fixed in master branch and are not necessary to migrate from gradle to maven build, so we use here 1.3.1 - added target to .gitignore because we want no build output inside git
- using now asp 1.3.2 which provides used asciidoctorj api version as a compile dependency - added the asciidoctor api dependency to MANIFEST.MF as well
- with "mvn clean verify" the update site will be now build completely automatically and contains the libraries inside, so no longer a need for a big dist jar! - currently the library jars which do not include a OSGI manifest information are handled as "wrapped..." dependencies
# Conflicts: # asciidoctor-editor-feature/feature.xml # asciidoctor-editor-libs/META-INF/MANIFEST.MF # asciidoctor-editor-plugin/META-INF/MANIFEST.MF # asciidoctor-editor-plugin/build.properties # asciidoctor-editor-updatesite/site.xml
- built main plugin did not contain any classes. The reason was the missing entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR