Open
Conversation
* Check everywhere that could use a ref script (not sure if everyone it's allowed) * Duplicate size for different ref inptus with the same ref script as per Haskell code * look in spent inputs too (as this is possible to ref a script from) Possibly addresses #354
SebastienGllmt
approved these changes
Sep 11, 2024
Contributor
SebastienGllmt
left a comment
SebastienGllmt
left a comment
There was a problem hiding this comment.
Are there any test vectors for this?
Contributor
Author
|
I'm going to wait at least a little bit until we can see if #354 is fixed by this before merging. If the guy who made the issue responds with what the actual inputs were (he only posted final cbor so any utxo/orig script info isn't preserved) then we can make test vectors out of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check everywhere that could use a ref script (not sure if it's allowed in all these spots)
Duplicate size for different ref inputs with the same ref script as per Haskell code
look in spent inputs too (as this is possible to ref a script from)
Possibly addresses #354