Give toolbar tests the sqlexecute property#1722
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Conversation
|
Findings:
Security concerns:
Validation note:
|
Now that the prompt string can have data fetched from the connection, and now that the toolbar can have custom format strings, there are assertions in get_prompt() that we should satisfy in toolbar tests, by setting the sqlexecute property.
0a64c3e to
86c1f54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that the prompt string can have data fetched from the connection, and now that the toolbar can have custom format strings, there are assertions in
get_prompt()that we should satisfy in toolbar tests, by setting thesqlexecuteproperty.It's not clear how this has been passing up until now in CI.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).