Merged
Conversation
|
I’m blocked from performing the review in this environment: every shell command fails before execution with
So I can’t access Please share one of these, and I’ll immediately give a concise, actionable review:
git log --oneline 77a3fe5d7f8b1a1814c9ab4e4b30cab535959a6e...8c85a94931873168b723f217ffb984caaf534df9
git diff --unified=3 77a3fe5d7f8b1a1814c9ab4e4b30cab535959a6e...8c85a94931873168b723f217ffb984caaf534df9
|
Contributor
Author
|
This seems to be required for the CI environment, which is hard to understand. But an upgrade is reasonable; it has the upstream fix for warnings on sqlglotrs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI massively failed in #1714, and this is an experiment to see if upgrading sqlglot fixes the issue.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).