Add data-content='item' attribute to the generated span tags.#26
Closed
briandmcnabb wants to merge 3 commits intodavatron5000:masterfrom
briandmcnabb:master
Closed
Add data-content='item' attribute to the generated span tags.#26briandmcnabb wants to merge 3 commits intodavatron5000:masterfrom briandmcnabb:master
briandmcnabb wants to merge 3 commits intodavatron5000:masterfrom
briandmcnabb:master
Conversation
…ok for styling with :before and :after pseudo elements, e.g.
span.char1:before {
content: attr(data-content);
...
}
Owner
|
Cool idea. One thought... for a |
Author
|
Sorry it took so long to address this... got busy. Didn't want you to think I flaked. Either way, the commit above should take care of escaping any " characters. |
Owner
|
Going to merge this into #45. Thanks for your original commits @briandmcnabb. Appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add data-content='item' attribute to the generated span tags.
This hook allows for dynamic use of :before and :after pseudo elements to layer text by way of a attr() call.
No more hard coding textual content in css files!