Open
Conversation
Member
|
Thanks for the PR! This is possible, if not a bit unconventional, because you can of course already read with However, I think this needs tests. Especially this should have a test where you first create a sparse file (with a large enough deleted section that a hole is actually created) and then take out this BufReader and read over the hole. It most likely does work and gives zeroes, but should IMO still be verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose one: is this a 🐛 bug fix, a 🙋 feature, or a 🔦 documentation change?
🙋 feature
Checklist
Context
I have a case where I store RandomAccessDisk in struct like this
It's quite common to do buffered read so I expose
reader()method.Accessing the underlying
fs::Fileis possible by callingreader().get_ref()orreader().get_mut().The
reader()method open up the possibility for this patternSemver Changes
3.1.0