Conversation
cowlicks
commented
May 20, 2025
cowlicks
commented
May 20, 2025
cowlicks
force-pushed
the
refactor-encryption
branch
from
90f081c to
8ef2e2f
Compare
cowlicks
force-pushed
the
refactor-encryption
branch
from
e257fce to
6658eb7
Compare
cowlicks
force-pushed
the
refactor-encryption
branch
from
a510948 to
87570a3
Compare
cowlicks
force-pushed
the
refactor-encryption
branch
2 times, most recently
from
88481d8 to
c429d8d
Compare
cowlicks
force-pushed
the
refactor-encryption
branch
from
3fdbce5 to
fb8b344
Compare
it's handled in hypercore handshake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIG CHANGES.
hypercore_handshakeanduint24le_framingrespectively. This had big impacts on the public API. NowProtocol::newjust takes aimpl CipherTraitargument. This was done because setting up encrypted connection should be handled by peer-discovery.hypercoreinstead we usehypercore_schema.