Skip to content

Conversation

@zero-zero-senven
Copy link
Contributor

@zero-zero-senven zero-zero-senven commented Jul 17, 2025

Purpose of this pull request

When using the "Error Data Store" function, I encountered :
for input string: "false" was reported.
Through the investigation of the stack reporting the error, I found


code:

  private void sinkErrorData() {
      ....
      case BYTE_TYPE:
          if (StringUtils.isNotEmpty(rowContent)) {
              errorDataPreparedStatement.setByte(j+1, Byte.parseByte(rowContent));
          } else {
              errorDataPreparedStatement.setNull(j+1, Types.TINYINT);
          }
          break;
          ...
    }

no processing TinyInt types of data, because the results of a query for TinyInt type field to true/false, And in SqlUtils, the values were directly converted to strings.
Therefore, I decided to handle true/false separately here and restore them to 1/0

Check list

  • Code changed are covered with tests, or it does not need tests for reason:
  • Change does not need document change

@zixi0825 zixi0825 merged commit a6dab5c into datavane:dev Jul 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants