Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@master
with:
node-version: '16'
node-version: '20'
check-latest: true
- name: Build vue components
run: |
Expand All @@ -44,7 +44,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@master
with:
node-version: '16'
node-version: '20'
check-latest: true
- name: Run unit tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.18
v20.18.0
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16 AS ui-build
FROM node:20.18.0 AS ui-build

WORKDIR /build

Expand All @@ -14,7 +14,7 @@ RUN chmod -R g=u /build/dist
#
# build node app in the next stage
#
FROM node:16.18-alpine
FROM node:20.18.0-alpine

LABEL maintainer="ming luo"

Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The admin console is a VueJS application that runs in a browser. It also include

To install the Pulsar Admin Console:

1. Ensure [node](https://nodejs.org/en/download/) version 16.15 or higher is installed.
1. Ensure [node](https://nodejs.org/en/download/) version 20.18 or higher is installed.

2. Download the latest release tarball from the [release page](https://github.com/datastax/pulsar-admin-console/releases).

Expand Down Expand Up @@ -145,9 +145,9 @@ The [DataStax Pulsar Helm Chart](https://github.com/datastax/pulsar-helm-chart)
Use these versions of node and npm:
```
$ npm -v
6.14.15
10.8.0
$ node -v
v14.18.3
v20.18.0
```

In order to easily manage your node and npm versions across developer machines, we use [nvm](https://github.com/nvm-sh/nvm). We set the node version in the [.nvmrc](./.nvmrc) file. In order to set up your environment, open a shell, change to the project directory, and run the following:
Expand All @@ -163,10 +163,10 @@ When upgrading versions of node, we should make sure to use LTS versions. You ca
nvm list
```

Then, pick which `lts/` version to use. Currently, we use `fermium`, so you can run the following:
Then, pick which `lts/` version to use. Currently, we use `iron`, so you can run the following:

```shell
nvm install lts/fermium
nvm install lts/iron
```

When upgrading node versions, make sure to update the [Dockerfile](./Dockerfile), the [.nvmrc](./.nvmrc) file, and the CI scripts (i.e. [.github/](./github/)).
Expand Down
4 changes: 2 additions & 2 deletions dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@
"moment": "^2.29.4"
},
"engines": {
"node": "^16.15.1",
"npm": "^8.11.0"
"node": "^20.18.0",
"npm": "^10.8.0"
},
"gitHooks": {
"pre-commit": "lint-staged"
Expand Down
4 changes: 2 additions & 2 deletions server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "backend of dashboard",
"main": "server.js",
"engines": {
"node": "^16.15.1",
"npm": "^8.11.0"
"node": "^20.18.0",
"npm": "^10.8.0"
},
"scripts": {
"serve": "node server.js",
Expand Down