Configurable baseDir and bastionBaseDir#189
Merged
michaelsembwever merged 1 commit intomasterfrom Nov 4, 2025
Merged
Conversation
c0d6674 to
b725394
Compare
|
Looks good to me. However, I think Yasser Mohamed asked for this, so it'll be good to get his input whether it covers the use case he had in mind. |
|
Looks good to me @michaelsembwever and just the comment for the make file for refactoring or optimization. |
Member
Author
|
thanks @yassermohamed81 , will take a look soon (haven't forgotten). doing too much scripting in the Makefile can be awkward, but improving it's checks and messaging is definitely warranted 👍 |
yassermohamed81
approved these changes
Nov 3, 2025
b725394 to
50f2db7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to
collector.conf