Updating the read me to include more details about the cqlsh_host con…#107
Open
AndrewHogg wants to merge 1 commit intomasterfrom
Open
Updating the read me to include more details about the cqlsh_host con…#107AndrewHogg wants to merge 1 commit intomasterfrom
AndrewHogg wants to merge 1 commit intomasterfrom
Conversation
…figuration value and an example of using an AWS command to resolve the node IP address to the local private IP
michaelsembwever
requested changes
Feb 2, 2022
| sed -i 's/^#?keepArtifact=.*/keepArtifact=\"true\"/' | ||
| ``` | ||
|
|
||
| * If the script fails when attempting to run the `cqlsh` command due to an incorrect host address, an additional configuration item can be uncommented and used to supply a suitable host value. The default behaviour of the setting is that a node will use the `hostname` command to provide the address to use as it is run on the node. Problems occur if this hostname does not resolve to the IP address that the node is listening for connections on. An alternative command can be used instead, which is supplied via configuration. |
Member
There was a problem hiding this comment.
we need to make mention that it is recommended and normal to first configure cqlHost.
that this is only needed when the hostname cannot be a standard ip/hostname on all nodes, and not $(hostname)
Member
There was a problem hiding this comment.
I still curious if this comment/info is better here or here: https://github.com/datastax/diagnostic-collection/blob/master/ds-collector/collector.conf.in#L139
| An example of a replacement when running on AWS to use the local private IP is: | ||
|
|
||
| ``` | ||
| cqlsh_host="$(curl http://169.254.169.254/latest/meta-data/local-ipv4)" |
Member
There was a problem hiding this comment.
have we tested this works in the configuration file? if it does, this it would make more sense that the line https://github.com/datastax/diagnostic-collection/blob/master/ds-collector/collector.conf.in#L139
was uncommented like
cqlsh_host="$(hostname)"
202d5c9 to
6c30051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…figuration value and an example of using an AWS command to resolve the node IP address to the local private IP