HCD-267: Fix the node UP/DOWN detection for DSE nodes#3
Draft
szymon-miezal wants to merge 2 commits intoconverged-cassandrafrom
Draft
HCD-267: Fix the node UP/DOWN detection for DSE nodes#3szymon-miezal wants to merge 2 commits intoconverged-cassandrafrom
szymon-miezal wants to merge 2 commits intoconverged-cassandrafrom
Conversation
szymon-miezal
force-pushed
the
HCD-267
branch
from
6f49864 to
a822d8b
Compare
szymon-miezal
commented
Feb 13, 2026
| } | ||
|
|
||
| if self.cassandra_version() >= '4.0': | ||
| if self.cassandra_version() >= '4.0' and self.getNodeClass() is Node: |
Author
There was a problem hiding this comment.
It's a guard against putting the enabled value for DSE which does not parse it.
szymon-miezal
commented
Feb 13, 2026
| self._update_config() | ||
|
|
||
| def enable_internode_ssl(self, node_ssl_path): | ||
| def enable_internode_ssl(self, node_ssl_path, enable_legacy_ssl_storage_port=False): |
Author
There was a problem hiding this comment.
A convenient change needed for testing DSE upgrades
szymon-miezal
commented
Feb 13, 2026
|
|
||
| if wait_other_notice: | ||
| marks = [(node, node.mark_log()) for node in list(self.cluster.nodes.values()) if node.is_live()] | ||
| marks = [(node, node.mark_log()) for node in list(self.cluster.nodes.values()) if node.is_live() and node is not self] |
Author
There was a problem hiding this comment.
Is there are reason we should be parsing our own logs?
szymon-miezal
force-pushed
the
HCD-267
branch
from
79273b0 to
18d4650
Compare
…tion - Add support for enable_legacy_ssl_storage_port in internode SSL setup - Fix address_for_version() to return address:port format for DSE 4.0+ - Override watch_log_for_alive() for DSE-specific log format - Add watch_log_for_death() method for DSE nodes - Fix wait_other_notice to exclude self from notification marks
szymon-miezal
force-pushed
the
HCD-267
branch
from
18d4650 to
925902f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.