-
Notifications
You must be signed in to change notification settings - Fork 18
Add --assume-ready for image and extra-inputs #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Code Climate has analyzed commit 380ead9 and detected 0 issues on this pull request. View more on Code Climate. |
yarikoptic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just initial peek.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 93.88% 94.07% +0.18%
==========================================
Files 24 24
Lines 1112 1147 +35
==========================================
+ Hits 1044 1079 +35
Misses 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yarikoptic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor recommendations but overall I think it should be ok.
But now it would need some basic test added since code with tests is ... broken code ;) See e.g. recently added tests for extra_inputs handling in https://github.com/datalad/datalad-container/blob/HEAD/datalad_container/tests/test_run.py#L195
|
I will move it to Draft. Please bring it back to "Ready for Review" whenever it gets extended with a test @bpinsard . |
|
ping @bpinsard any time to finish this one up? |
a429479 to
a7686a5
Compare
39bada2 to
93267c9
Compare
Co-authored-by: Yaroslav Halchenko <[email protected]>
Co-authored-by: Yaroslav Halchenko <[email protected]>
380ead9 to
037de79
Compare
Add
--assume-readyoption to be passed torun, with extra options forimageandextra-inputs.see #199 .
TODOs