-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add search to metrics pages #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ThibaudDauce
wants to merge
2
commits into
main
Choose a base branch
from
add_search_to_metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import { test, expect } from '@playwright/test' | ||
|
|
||
| const API_BASE = process.env.NUXT_PUBLIC_API_BASE || 'http://dev.local:7000' | ||
|
|
||
| test.describe('Dataset metrics', () => { | ||
| let datasetA: { id: string, title: string } | ||
| let datasetB: { id: string, title: string } | ||
| const uniqueId = Date.now() | ||
|
|
||
| test.beforeAll(async ({ browser }) => { | ||
| const context = await browser.newContext({ storageState: 'playwright/.auth/user.json' }) | ||
| const page = await context.newPage() | ||
|
|
||
| const [respA, respB] = await Promise.all([ | ||
| page.request.post(`${API_BASE}/api/1/datasets/`, { | ||
| data: { title: `Alpha metrics ${uniqueId}`, description: 'Test', frequency: 'unknown' }, | ||
| }), | ||
| page.request.post(`${API_BASE}/api/1/datasets/`, { | ||
| data: { title: `Beta metrics ${uniqueId}`, description: 'Test', frequency: 'unknown' }, | ||
| }), | ||
| ]) | ||
| datasetA = await respA.json() | ||
| datasetB = await respB.json() | ||
|
|
||
| await context.close() | ||
| }) | ||
|
|
||
| test.afterAll(async ({ browser }) => { | ||
| const context = await browser.newContext({ storageState: 'playwright/.auth/user.json' }) | ||
| const page = await context.newPage() | ||
|
|
||
| await Promise.all([ | ||
| page.request.delete(`${API_BASE}/api/1/datasets/${datasetA.id}/`), | ||
| page.request.delete(`${API_BASE}/api/1/datasets/${datasetB.id}/`), | ||
| ]) | ||
|
|
||
| await context.close() | ||
| }) | ||
|
|
||
| test('lists datasets with their metrics', async ({ page }) => { | ||
| await page.goto('/admin/me/metrics/datasets/') | ||
|
|
||
| await expect(page.getByRole('link', { name: datasetA.title })).toBeVisible() | ||
| await expect(page.getByRole('link', { name: datasetB.title })).toBeVisible() | ||
| }) | ||
|
|
||
| test('can search datasets by title', async ({ page }) => { | ||
| await page.goto('/admin/me/metrics/datasets/') | ||
|
|
||
| const searchInput = page.getByRole('searchbox', { name: 'Recherche' }) | ||
| await expect(searchInput).toBeVisible() | ||
|
|
||
| await searchInput.fill(`Alpha metrics ${uniqueId}`) | ||
| await expect(page.getByRole('link', { name: datasetA.title })).toBeVisible() | ||
| await expect(page.getByRole('link', { name: datasetB.title })).not.toBeVisible() | ||
|
|
||
| await searchInput.clear() | ||
| await expect(page.getByRole('link', { name: datasetA.title })).toBeVisible() | ||
| await expect(page.getByRole('link', { name: datasetB.title })).toBeVisible() | ||
| }) | ||
|
|
||
| test('shows empty state and reset button when search has no results', async ({ page }) => { | ||
| await page.goto('/admin/me/metrics/datasets/') | ||
|
|
||
| const searchInput = page.getByRole('searchbox', { name: 'Recherche' }) | ||
| await searchInput.fill('zzz-no-match-zzz') | ||
|
|
||
| await expect(page.getByText('Pas de résultats pour « zzz-no-match-zzz »')).toBeVisible() | ||
|
|
||
| await page.getByRole('button', { name: 'Réinitialiser les filtres' }).click() | ||
|
|
||
| await expect(searchInput).toHaveValue('') | ||
| await expect(page.getByRole('link', { name: datasetA.title })).toBeVisible() | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
page should go back to 1 when qDebounced changes (for all 3 searches)