feat: handle transfer request notification #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskempf57
requested review from
ThibaudDauce and
maudetes
as code owners
ThibaudDauce
approved these changes
Dec 31, 2025
| const source = props.notification.details.transfer_owner | ||
| const sourceName = 'first_name' in source ? `${source.first_name} ${source.last_name}` : source.name | ||
| const subject = props.notification.details.transfer_subject | ||
| const subjectPath = `${subject.class.toLowerCase()}s` |
Contributor
There was a problem hiding this comment.
Is it possible to have a explicit mapping if there is not a lot of subjects types?
| const details = computed(() => { | ||
| const recipient = props.notification.details.transfer_recipient | ||
| const source = props.notification.details.transfer_owner | ||
| const sourceName = 'first_name' in source ? `${source.first_name} ${source.last_name}` : source.name |
Contributor
There was a problem hiding this comment.
Is this working:
Suggested change
| const sourceName = 'first_name' in source ? `${source.first_name} ${source.last_name}` : source.name | |
| const sourceName = source.class === 'User' ? `${source.first_name} ${source.last_name}` : source.name |
Contributor
Author
There was a problem hiding this comment.
I'll update the OrganizationReference and UserReference types to have the class and then pray that typescript is smart
| const sourceName = 'first_name' in source ? `${source.first_name} ${source.last_name}` : source.name | ||
| const subject = props.notification.details.transfer_subject | ||
| const subjectPath = `${subject.class.toLowerCase()}s` | ||
| if ('first_name' in recipient) { |
Contributor
There was a problem hiding this comment.
Can we use recipient.class instead?
Suggested change
| if ('first_name' in recipient) { | |
| if (recipient.class === 'User') { |
Contributor
|
I think it could be merge before the udata part without any conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.