issue NewValidation: CSCwi17652 check for service-ep flag #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support multithread execution * fix: switch_ssd_check regex and add pytest * fix: MANUAL instead of ERROR when switch bootflash objects not found * fix: MANUAL instead of ERROR when switch sup objects not found * bump to v3.4.13 * feat: Add fabricNode in common_data * fix: fallback on firmware queries on older ACI version to get current ver * fix: fallback to infraWiNode with pre-4.0 without fabricNode.address * test: fail mock_icurl when test data is not provided * fix: Change error message for API timeout * fix: raise exception with empty imdata with totalCount>1 * fix: pytest error for version display * fix: Abort correctly when user is not authorized to access firmwareCtrlrRunning * fix: Output from a timed out test thread task impacts other tests result * fix: Raise exception with empty imdata with totalCount>0. Handle docker0 check error individually * Bump to v4.0.0
* updated vmm_inventory_partial_sync to align with v3.0 paradigm * Enhanced by looking for changeset partial-inv to avoid flagging on the other reasons. * merge mater + fix pytest --------- Co-authored-by: Gabriel <[email protected]>
…pported to pre-6.2.1 version. (#289) * feat: Add pre-upgrade warning for APIC 6.2.1 that downgrade is not supported to pre-6.2.1 version. --------- Co-authored-by: Saket <[email protected]> Co-authored-by: tkishida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294 fixed
Lab output:
[Check 88/88] Service-EP Flag in BD without PBR... FAIL - OUTAGE WARNING!!
Tenant Bridge Domain Service Graph Device Device Node Name
CIB Prod-LB-IN_BD Prod_FTD_LB_Local N2
CIB Prod-LB-Out_BD Prod-FW-LB-SG node2
CIB Prod-LB-Out_BD Prod-FW-LB-SG node2
CIB Prod-LB-Out_BD Prod_FTD_LB_Local N2
CIB Prod-LB-Out_BD Prod_FTD_LB_Local N2
DMZ-TN BD-L3-MPG01-IWF-EGR SG-IWF-MPG01-TEMPLATE IWF-MPG01
DMZ-TN BD-L3-MPG02-IWF-EGR SG-IWF-MPG02-TEMPLATE IWF-MPG02
aperezos PBR_in FTGA-EW N1
Recommended Action:
Confirm that within these BDs the PBR configuration is complete.
Please check the reference document for details.
Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#service-ep-flag-in-bd-without-pbr
jeestrad@JEESTRAD-M-L6VV ACI-Pre-Upgrade-Validation-Script % python3 -m pytest tests/service-ep_flag_bd_check
============================================================================================= test session starts =============================================================================================
platform darwin -- Python 3.9.6, pytest-8.2.0, pluggy-1.5.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
plugins: anyio-4.8.0
collected 7 items
tests/service-ep_flag_bd_check/test_service-ep_flag_bd_check.py::test_logic[icurl_outputs0-5.2(8h)-None-MANUAL CHECK REQUIRED]
----------------------------------------------------------------------------------------------- live log setup ------------------------------------------------------------------------------------------------
[15:19:43.876 INFO initialize:5653] Cleaning up previous run files in preupgrade_validator_logs/
[15:19:43.877 INFO initialize:5655] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
PASSED [ 14%]
tests/service-ep_flag_bd_check/test_service-ep_flag_bd_check.py::test_logic[icurl_outputs1-6.0(8h)-6.1(1g)-N/A] PASSED [ 28%]
tests/service-ep_flag_bd_check/test_service-ep_flag_bd_check.py::test_logic[icurl_outputs2-4.2(7s)-5.2(4c)-N/A] PASSED [ 42%]
tests/service-ep_flag_bd_check/test_service-ep_flag_bd_check.py::test_logic[icurl_outputs3-5.2(8h)-6.0(8e)-FAIL - OUTAGE WARNING!!] PASSED [ 57%]
tests/service-ep_flag_bd_check/test_service-ep_flag_bd_check.py::test_logic[icurl_outputs4-5.2(8h)-6.1(1f)-FAIL - OUTAGE WARNING!!] PASSED [ 71%]
tests/service-ep_flag_bd_check/test_service-ep_flag_bd_check.py::test_logic[icurl_outputs5-5.2(8h)-6.0(8e)-PASS] PASSED [ 85%]
tests/service-ep_flag_bd_check/test_service-ep_flag_bd_check.py::test_logic[icurl_outputs6-5.2(8h)-6.1(1f)-PASS] PASSED [100%]
============================================================================================== 7 passed in 0.03s ==============================================================================================
jeestrad@JEESTRAD-M-L6VV ACI-Pre-Upgrade-Validation-Script %