-
Notifications
You must be signed in to change notification settings - Fork 14
Handle TRACE-level logging
#318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…I handoff. Also ensure we never crash if the log-level is unknown.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
=======================================
Coverage ? 80.05%
=======================================
Files ? 17
Lines ? 2396
Branches ? 516
=======================================
Hits ? 1918
Misses ? 354
Partials ? 124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 40/40 passed, 2 skipped, 1m44s total Running from acceptance #369 |
m-abulazm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- **TRACE-level logging support** [#318](#318) Added support for `TRACE`-level logs by mapping them to `DEBUG`, since Python lacks native `TRACE` support. Introduced a new method to translate Databricks CLI log levels to Python levels, defaulting to `INFO` when unknown. Improved error logging for better debugging and reporting. - **Python 3.14 compatibility** [#315](#315) The project now supports Python 3.10–3.14. CI tests have been updated accordingly, and project metadata now reflects Python 3.14 and beta development status. Minimum requirements remain: Python 3.10+ and `databricks-sdk` 0.16.0+. - **Line-based subprocess streaming** [#320](#320) Added real-time, line-based reading of subprocess output via a new `readlines` function. It decodes UTF-8 safely, manages memory efficiently, and handles very long lines without blocking. Also added `pytest-asyncio` to improve async code testing. - **Hatch upgrade** [#311](#311) Upgraded Hatch from 1.9.4 → 1.14.2 to fix compatibility issues (notably with Click 8.3.0) and improve build performance. Removed the old Click version constraint so newer versions can be installed.
# Release Notes - **TRACE-level logging support** [#318](#318) Added support for `TRACE`-level logs by mapping them to `DEBUG`, since Python lacks native `TRACE` support. Introduced a new method to translate Databricks CLI log levels to Python levels, defaulting to `INFO` when unknown. Improved error logging for better debugging and reporting. - **Python 3.14 compatibility** [#315](#315) The project now supports Python 3.10–3.14. CI tests have been updated accordingly, and project metadata now reflects Python 3.14 and beta development status. Minimum requirements remain: Python 3.10+ and `databricks-sdk` 0.16.0+. - **Line-based subprocess streaming** [#320](#320) Added real-time, line-based reading of subprocess output via a new `readlines` function. It decodes UTF-8 safely, manages memory efficiently, and handles very long lines without blocking. Also added `pytest-asyncio` to improve async code testing. - **Hatch upgrade** [#311](#311) Upgraded Hatch from 1.9.4 → 1.14.2 to fix compatibility issues (notably with Click 8.3.0) and improve build performance. Removed the old Click version constraint so newer versions can be installed.
This PR updates the logging set up during handoff from the Databricks CLI so that
TRACE-level logging doesn't trigger a crash. Because Python doesn't supportTRACEas a logging level we map this toDEBUG.In addition, rather than crash when an unknown log-level is encountered we now log a warning and proceed with
INFOinstead.Resolves #317.
This has been tested manually with
lakebridge.