Skip to content

Conversation

@sundarshankar89
Copy link
Collaborator

  • Added Password Prompt to operate with echo off in terminal (#265). The command-line interface now includes a secure password prompt feature, allowing users to enter sensitive information without it being visible on the screen. This is achieved through a new method that utilizes the getpass library to hide user input when entering passwords, taking a prompt message and an optional maximum number of attempts as parameters. The method repeatedly prompts the user for a password until a valid input is provided or the maximum number of attempts is reached, at which point it raises a ValueError. This addition enhances the security and usability of the interface, and its functionality is validated through new test methods that cover both successful password entry and the scenario where the maximum number of attempts is exceeded, ensuring the feature behaves as expected in various situations.
  • Sniff encoding properly in XML files with a standalone directive (#256). The XML file encoding detection has been improved to support a wider range of valid XML declarations. The regular expression used to match XML declarations has been updated to correctly handle cases where both encoding and standalone attributes are present, such as <?xml version="1.x" encoding="xxx" standalone="yes"?>. This change enables more accurate detection of the encoding attribute in XML files, even when a standalone directive is present. Additionally, test functions have been added and modified to verify this functionality, including tests for XML files with a BOM prefix and those with an XML standalone declaration, ensuring that the code can correctly read these files and detect the encoding.

* Added Password Prompt to operate with echo off in terminal ([#265](#265)). The command-line interface now includes a secure password prompt feature, allowing users to enter sensitive information without it being visible on the screen. This is achieved through a new method that utilizes the `getpass` library to hide user input when entering passwords, taking a prompt message and an optional maximum number of attempts as parameters. The method repeatedly prompts the user for a password until a valid input is provided or the maximum number of attempts is reached, at which point it raises a `ValueError`. This addition enhances the security and usability of the interface, and its functionality is validated through new test methods that cover both successful password entry and the scenario where the maximum number of attempts is exceeded, ensuring the feature behaves as expected in various situations.
* Sniff encoding properly in XML files with a standalone directive ([#256](#256)). The XML file encoding detection has been improved to support a wider range of valid XML declarations. The regular expression used to match XML declarations has been updated to correctly handle cases where both `encoding` and `standalone` attributes are present, such as `<?xml version="1.x" encoding="xxx" standalone="yes"?>`. This change enables more accurate detection of the encoding attribute in XML files, even when a `standalone` directive is present. Additionally, test functions have been added and modified to verify this functionality, including tests for XML files with a BOM prefix and those with an XML standalone declaration, ensuring that the code can correctly read these files and detect the encoding.
@sundarshankar89 sundarshankar89 requested a review from nfx as a code owner October 6, 2025 08:39
@sundarshankar89 sundarshankar89 requested review from asnare and gueniai and removed request for nfx October 6, 2025 08:39
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

✅ 40/40 passed, 2 skipped, 1m32s total

Running from acceptance #364

@sundarshankar89 sundarshankar89 merged commit 250fa26 into main Oct 6, 2025
11 checks passed
@sundarshankar89 sundarshankar89 deleted the prepare/0.11.4 branch October 6, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants