Skip to content

BUG: torch: expand_dims axis is keyword or positional argument #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ev-br merged 3 commits into from
Feb 24, 2026
Merged

BUG: torch: expand_dims axis is keyword or positional argument #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ececee
TST: dask: xfail searchorted_scalars test on dask
ev-br Jan 8, 2026
f486969
TST: add skips for dask/expand_dims and numpy<2 isin
ev-br Feb 24, 2026
35b06e5
BUG: torch: expand_dims axis is keyword or positional
ev-br Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion array_api_compat/torch/_aliases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ def triu(x: Array, /, *, k: int = 0) -> Array:
return torch.triu(x, k)

# Functions that aren't in torch https://github.com/pytorch/pytorch/issues/58742
def expand_dims(x: Array, /, *, axis: int | tuple[int, ...]) -> Array:
def expand_dims(x: Array, /, axis: int | tuple[int, ...]) -> Array:
if isinstance(axis, int):
return torch.unsqueeze(x, axis)
else:
Expand Down
3 changes: 3 additions & 0 deletions dask-xfails.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,13 @@ array_api_tests/test_signatures.py::test_func_signature[broadcast_shapes]
array_api_tests/test_data_type_functions.py::TestBroadcastShapes::test_broadcast_shapes
array_api_tests/test_data_type_functions.py::TestBroadcastShapes::test_empty
array_api_tests/test_data_type_functions.py::TestBroadcastShapes::test_error
array_api_tests/test_searching_functions.py::test_searchsorted_with_scalars

array_api_tests/test_linalg.py::test_eig
array_api_tests/test_linalg.py::test_eigvals

array_api_tests/test_manipulation_functions.py::TestExpandDims::test_expand_dims_tuples

# Stubs have a comment: (**note**: libraries may return ``NaN`` to match Python behavior.)
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i > 0) -> +infinity]
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i < 0) -> -infinity]
Expand Down
2 changes: 2 additions & 0 deletions numpy-1-26-xfails.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ array_api_tests/test_operators_and_elementwise_functions.py::test_where_with_sca
array_api_tests/test_creation_functions.py::test_meshgrid
array_api_tests/test_data_type_functions.py::test_broadcast_arrays

# observed with numpy==1.26 only, looks like is fixed on numpy 2.x
array_api_tests/test_set_functions.py::TestIsin::test_isin_scalars

# Stubs have a comment: (**note**: libraries may return ``NaN`` to match Python behavior.); Apparently, NumPy does just that
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i > 0) -> +infinity]
Expand Down
Loading