refactor(sdk)!: comprehensive Evo SDK refactoring

.github/actions/nodejs/action.yaml

@@ -5,7 +5,7 @@ inputs:
   node-version:
     description: "Node.js version to use"
     required: false
-    default: "20"
+    default: "24"
 runs:
   using: composite
   steps:

.github/workflows/prebuild-devcontainers.yml

@@ -27,7 +27,7 @@ jobs:
       - name: Setup Node.JS
         uses: actions/setup-node@v4
         with:
-          node-version: "20"
+          node-version: "24"
 
       - name: Install skopeo
         run: |

.github/workflows/tests.yml

@@ -158,7 +158,7 @@ jobs:
       - name: Setup Node.JS
         uses: actions/setup-node@v4
         with:
-          node-version: "20"
+          node-version: "24"
 
       - name: Enable corepack
         run: corepack enable

eslint/base.mjs

@@ -0,0 +1,86 @@
+import { configs, plugins } from 'eslint-config-airbnb-extended';
+import globals from 'globals';
+
+/**
+ * Base ESLint configuration for all packages.
+ * Contains common rules and overrides used across the monorepo.
+ */
+export const baseConfig = [
+  // Register the plugins required by airbnb-extended
+  // Each plugin export is a config object with nested plugins
+  plugins.stylistic,
+  plugins.importX,
+  plugins.node,
+  ...configs.base.recommended,
+  {
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: 'module',
+      parserOptions: {
+        ecmaVersion: 2022,
+        sourceType: 'module',
+      },
+      globals: {
+        ...globals.node,
+        BigInt: 'readonly',
+      },
+    },
+    rules: {
+      // Common overrides from existing configs
+      'no-plusplus': 'off',
+      'eol-last': ['error', 'always'],
+      'class-methods-use-this': 'off',
+      curly: ['warn', 'all'],
+      'no-await-in-loop': 'off',
+      'no-continue': 'off',
+      // Custom restricted syntax - remove ForOfStatement restriction from airbnb
+      'no-restricted-syntax': [
+        'error',
+        {
+          selector: 'LabeledStatement',
+          message: 'Labels are a form of GOTO; using them makes code confusing.',
+        },
+        {
+          selector: 'WithStatement',
+          message: '`with` is disallowed in strict mode.',
+        },
+      ],
+      // Disable import-x rules that don't work well in monorepo
+      'import-x/no-relative-packages': 'off',
+      'import-x/extensions': 'off',
+      'import-x/no-named-as-default': 'off',
+      // Increase line length limit
+      '@stylistic/max-len': ['warn', { code: 120, ignoreStrings: true, ignoreTemplateLiterals: true, ignoreUrls: true, ignoreRegExpLiterals: true, ignoreComments: true }],
+      // Disable @stylistic rules that weren't enforced before
+      '@stylistic/indent': 'off',
+      '@stylistic/brace-style': 'off',
+      '@stylistic/max-statements-per-line': 'off',
+      '@stylistic/operator-linebreak': 'off',
+      '@stylistic/member-delimiter-style': 'off',
+      '@stylistic/type-annotation-spacing': 'off',
+      '@stylistic/arrow-parens': 'off',
+      '@stylistic/arrow-spacing': 'off',
+      '@stylistic/semi': 'off',
+      '@stylistic/comma-spacing': 'off',
+      '@stylistic/comma-dangle': 'off',
+      '@stylistic/quote-props': 'off',
+      '@stylistic/quotes': 'off',
+      '@stylistic/lines-between-class-members': 'off',
+      '@stylistic/object-curly-newline': 'off',
+      '@stylistic/no-mixed-operators': 'off',
+      // Disable other rules that weren't enforced before
+      'prefer-arrow-callback': 'off',
+      'prefer-object-has-own': 'off',
+      'no-new': 'off',
+      'no-restricted-exports': 'off',
+      // Disable import-x rules that cause too many warnings
+      'import-x/newline-after-import': 'off',
+      'import-x/no-useless-path-segments': 'off',
+      'import-x/no-rename-default': 'off',
+      'import-x/namespace': 'off',
+      'import-x/prefer-default-export': 'off',
+    },
+  },
+];
+
+export default baseConfig;

eslint/mocha-tests.mjs

@@ -0,0 +1,32 @@
+import globals from 'globals';
+
+/**
+ * Mocha test files ESLint configuration.
+ * Provides test-specific globals and rule relaxations.
+ */
+export const mochaTestConfig = {
+  files: [
+    '**/test/**/*.js',
+    '**/test/**/*.ts',
+    '**/tests/**/*.js',
+    '**/tests/**/*.ts',
+    '**/*.spec.js',
+    '**/*.spec.ts',
+    '**/test-d/**/*.ts',
+  ],
+  languageOptions: {
+    globals: {
+      ...globals.mocha,
+      expect: 'readonly',
+    },
+  },
+  rules: {
+    // Allow dev dependencies in tests
+    'import-x/no-extraneous-dependencies': 'off',
+    // dirty-chai uses property assertions
+    'no-unused-expressions': 'off',
+    '@typescript-eslint/no-unused-expressions': 'off',
+  },
+};
+
+export default mochaTestConfig;

eslint/typescript.mjs

@@ -0,0 +1,50 @@
+import { configs, plugins } from 'eslint-config-airbnb-extended';
+
+/**
+ * TypeScript ESLint configuration.
+ * Extends base config with TypeScript-specific rules and relaxations.
+ */
+export const typescriptConfig = [
+  // Register the TypeScript plugin
+  plugins.typescriptEslint,
+  ...configs.base.typescript,
+  {
+    files: ['**/*.ts', '**/*.tsx'],
+    rules: {
+      // Disable base rules that conflict with TypeScript versions
+      'no-return-await': 'off',
+      '@typescript-eslint/return-await': 'warn',
+      'no-unused-vars': 'off',
+      '@typescript-eslint/no-unused-vars': 'warn',
+      'no-shadow': 'off',
+      '@typescript-eslint/no-shadow': 'error',
+
+      // Relax strict TypeScript rules for backward compatibility
+      '@typescript-eslint/no-require-imports': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/ban-ts-comment': 'off',
+      '@typescript-eslint/no-unsafe-function-type': 'off',
+      '@typescript-eslint/no-this-alias': 'off',
+      '@typescript-eslint/no-namespace': 'off',
+      '@typescript-eslint/no-use-before-define': 'off',
+      'no-use-before-define': 'off',
+
+      // Disable new @typescript-eslint rules not previously enforced
+      '@typescript-eslint/consistent-indexed-object-style': 'off',
+      '@typescript-eslint/consistent-type-definitions': 'off',
+      '@typescript-eslint/no-inferrable-types': 'off',
+      '@typescript-eslint/array-type': 'off',
+      '@typescript-eslint/prefer-function-type': 'off',
+
+      // Import resolution handled by TypeScript
+      'import-x/extensions': 'off',
+      'import-x/no-unresolved': 'off',
+
+      // Disable @stylistic rules for TypeScript files (not previously enforced)
+      '@stylistic/member-delimiter-style': 'off',
+      '@stylistic/type-annotation-spacing': 'off',
+    },
+  },
+];
+
+export default typescriptConfig;

eslint/wasm.mjs

@@ -0,0 +1,25 @@
+/**
+ * WASM-specific ESLint configuration.
+ * Relaxes rules that conflict with WASM bindings and FFI patterns.
+ */
+export const wasmConfig = {
+  rules: {
+    // WASM bindings use __type, _wbg_ptr naming conventions
+    'no-underscore-dangle': 'off',
+    // Legitimate use in hex conversion and buffer operations
+    'no-bitwise': 'off',
+    // for-of loops are acceptable in modern TypeScript
+    'no-restricted-syntax': 'off',
+    // Extended line length for WASM binding code
+    'max-len': [
+      'error',
+      {
+        code: 140,
+        ignoreStrings: true,
+        ignoreTemplateLiterals: true,
+      },
+    ],
+  },
+};
+
+export default wasmConfig;

package.json

@@ -42,11 +42,17 @@
   },
   "devDependencies": {
     "@iarna/toml": "^2.2.5",
+    "@typescript-eslint/parser": "^8.0.0",
     "add-stream": "^1.0.0",
     "conventional-changelog": "^3.1.24",
     "conventional-changelog-dash": "github:dashevo/conventional-changelog-dash",
+    "eslint": "^9.18.0",
+    "eslint-config-airbnb-extended": "^3.0.1",
+    "eslint-plugin-jsdoc": "^50.6.3",
+    "globals": "^15.14.0",
     "semver": "^7.5.3",
     "tempfile": "^3.0.0",
+    "typescript": "^5.7.3",
     "ultra-runner": "^3.10.5"
   },
   "workspaces": [
@@ -75,6 +81,7 @@
     "packages/js-evo-sdk"
   ],
   "resolutions": {
+    "tar": "7.5.7",
     "pbkdf2": "^3.1.3",
     "elliptic": "6.6.1",
     "bn.js": "4.12.0",
@@ -108,7 +115,6 @@
     "cross-spawn": "^7.0.5",
     "nanoid": "^3.3.8",
     "tar-fs": "^3.0.9",
-    "tar": "^7.5.4",
     "brace-expansion": "^2.0.2",
     "cipher-base": "^1.0.5",
     "sha.js": "^2.4.12",

packages/bench-suite/benchmarks/basicValidation.js

@@ -2,7 +2,7 @@ const { PrivateKey } = require('@dashevo/dashcore-lib');
 
 const dpnsDocumentTypes = require('@dashevo/dpns-contract/schema/v1/dpns-contract-documents.json');
 
-// const { DashPlatformProtocol, Identity, Identifier, default: loadWasmDpp }  = require('@dashevo/wasm-dpp');
+const { Identity, Identifier } = require('@dashevo/wasm-dpp');
 const generateRandomIdentifier = require('@dashevo/wasm-dpp/lib/test/utils/generateRandomIdentifierAsync');
 
 const crypto = require('crypto');

packages/bench-suite/benchmarks/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable global-require */
-
 module.exports = [
   require('./documents/100string'),
   require('./documents/indices'),

packages/bench-suite/eslint.config.mjs

@@ -0,0 +1,8 @@
+import baseConfig from '../../eslint/base.mjs';
+
+export default [
+  ...baseConfig,
+  {
+    ignores: ['dist/**', 'node_modules/**'],
+  },
+];

packages/bench-suite/lib/Runner.js

@@ -49,7 +49,7 @@ class Runner {
    * @param {string} filePath
    */
   loadBenchmarks(filePath) {
-    // eslint-disable-next-line global-require,import/no-dynamic-require
+    // eslint-disable-next-line import-x/no-dynamic-require
     const benchmarks = require(filePath);
 
     for (const benchmarkConfig of benchmarks) {

packages/bench-suite/lib/metrics/drive/DriveMetricsCollector.js

@@ -48,7 +48,7 @@ class DriveMetricsCollector extends events.EventEmitter {
       let logData;
       try {
         logData = JSON.parse(line);
-      } catch (e) {
+      } catch {
         return;
       }
 

packages/bench-suite/package.json

@@ -5,7 +5,7 @@
   "description": "Dash Platform benchmark tool",
   "scripts": {
     "bench": "node ./bin/bench.js",
-    "lint": ""
+    "lint": "eslint ."
   },
   "dependencies": {
     "@dashevo/dashcore-lib": "~0.22.0",
@@ -20,10 +20,7 @@
     "mocha": "^11.1.0"
   },
   "devDependencies": {
-    "babel-eslint": "^10.1.0",
-    "eslint": "^8.53.0",
-    "eslint-config-airbnb-base": "^15.0.0",
-    "eslint-plugin-import": "^2.29.0"
+    "eslint": "^9.18.0"
   },
   "repository": {
     "type": "git",

packages/dapi-grpc/eslint.config.mjs

@@ -0,0 +1,11 @@
+import baseConfig from '../../eslint/base.mjs';
+import mochaTestConfig from '../../eslint/mocha-tests.mjs';
+
+export default [
+  ...baseConfig,
+  mochaTestConfig,
+  {
+    // Generated protobuf code - ignore clients and src generated directories
+    ignores: ['dist/**', 'node_modules/**', 'clients/**', 'src/**'],
+  },
+];